hdaikoku commented on a change in pull request #2866:
URL: https://github.com/apache/hadoop/pull/2866#discussion_r606920944
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/router/TestRouterRPCClientRetries.java
##########
@@ -155,10 +155,10 @@ public void testRetryWhenOneNameServiceDown() throws
Exception {
// Renew lease for the DFS client, it will succeed.
routerProtocol.renewLease(client.getClientName());
- // Verify the retry times, it will retry one time for ns0.
+ // Verify the retry times, it should succeed with no retry as long as at
least one of the nameservices is ACTIVE.
FederationRPCMetrics rpcMetrics = routerContext.getRouter()
.getRpcServer().getRPCMetrics();
- assertEquals(1, rpcMetrics.getProxyOpRetries());
+ assertEquals(0, rpcMetrics.getProxyOpRetries());
Review comment:
With this patch, ns0 is no longer a target nameservice of the renewLease
RPC and thus there should be no retries.
https://github.com/apache/hadoop/blob/02d578a9a1d2e084b609c24640c51a783a598464/hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java#L595-L596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
