Hexiaoqiao commented on pull request #2737: URL: https://github.com/apache/hadoop/pull/2737#issuecomment-819615655
> I think we also need to add some comments in the code to show why we don't shutdown this executor, in case some developers may get confused, because at the first glance it's also normal for people to think that this executor should shutdown on `close`. +1. > Furthermore, I think your argument implies that the `FSEditLogAsync` is singleton in terms of the namenode process, otherwise we may create multiple executors without shutting down any of them. Is `FSEditLogAsync` really always singleton (now & future)? IMO, it is true that `FSEditLogAsync` is singleton instance for NameNode process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
