amahussein commented on pull request #2737: URL: https://github.com/apache/hadoop/pull/2737#issuecomment-822510445
> @amahussein Thanks for your quick response. I think this is not the same concept/issue between [HDFS-15957](https://issues.apache.org/jira/browse/HDFS-15957) and [HDFS-15869](https://issues.apache.org/jira/browse/HDFS-15869). I have leave comment at [HDFS-15869](https://issues.apache.org/jira/browse/HDFS-15869) and suggest to change it to `improvement` rather than `bug fix`; (cc @functioner) > IMO, this is a classic Producer-Consumer problem, and it is natural idea to improve performance using parallel way. And Yiqun has reported the same issue at [HDFS-15486](https://issues.apache.org/jira/browse/HDFS-15486). In my own production env it was about 5% E2E saving time for write operation. > My suggestion, > A. Update description for improvement rather than bug fix. > B. If any concerns about lambda expression, we could improve it rather than reject it directly. > Welcome any more discussion. Thanks everyone here. Thanks @Hexiaoqiao Hexiaoqiao for the comment. Ok, is the purpose of the change is to improve performance of the `FSEditLogAsync.java` by executing `sendResponse()` in parallel? In that case, please change the title of the Jira and the description to remove references to "hanging" problems. Then I will take another look. I am sorry for the inconvenience as I want to make sure I understand the purpose of the change before revieweing. > @amahussein Thanks for the comment. > Can I send an email to you to explain more about the issue? @Hexiaoqiao and I have some more discussion on it, and some discussion is inconvenient to put in here. You can contact me via [[email protected]](mailto:[email protected]) or [[email protected]](mailto:[email protected]) and then I will reply. Thanks @functioner ! I really appreciate that. I think @Hexiaoqiao Hexiaoqiao reply already clarified some of the confusion about the scope of the work. Please feel free to reach me through email at anytime. I am on the common-dev mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
