[ https://issues.apache.org/jira/browse/HADOOP-17618?focusedWorklogId=587824&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587824 ]
ASF GitHub Bot logged work on HADOOP-17618: ------------------------------------------- Author: ASF GitHub Bot Created on: 23/Apr/21 12:57 Start Date: 23/Apr/21 12:57 Worklog Time Spent: 10m Work Description: sumangala-patki commented on a change in pull request #2845: URL: https://github.com/apache/hadoop/pull/2845#discussion_r619198007 ########## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/UriUtils.java ########## @@ -73,6 +98,63 @@ public static String generateUniqueTestPath() { return testUniqueForkId == null ? "/test" : "/" + testUniqueForkId + "/test"; } + public static String maskUrlQueryParameters(List<NameValuePair> keyValueList, + HashSet<String> queryParamsForFullMask, + HashSet<String> queryParamsForPartialMask) { + return maskUrlQueryParameters(keyValueList, queryParamsForFullMask, + queryParamsForPartialMask, 256); + } + + public static String maskUrlQueryParameters(List<NameValuePair> keyValueList, + HashSet<String> queryParamsForFullMask, + HashSet<String> queryParamsForPartialMask, int queryLen) { + StringBuilder maskedUrl = new StringBuilder(queryLen); + for (NameValuePair keyValuePair : keyValueList) { + String key = keyValuePair.getName(); + if (key.isEmpty()) { + throw new IllegalArgumentException("Query param key should not be empty"); + } + String value = keyValuePair.getValue(); + maskedUrl.append(key); + maskedUrl.append(EQUAL); + if (value != null && !value.isEmpty()) { //no mask + if (queryParamsForFullMask.contains(key)) { + maskedUrl.append(FULL_MASK); + } else if (queryParamsForPartialMask.contains(key)) { + int valueLen = value.length(); + int maskedLen = valueLen - Math.min(4, valueLen); Review comment: done [have modified const value to align with server logs masking logic] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 587824) Time Spent: 5h 50m (was: 5h 40m) > ABFS: Partially obfuscate SAS object IDs in Logs > ------------------------------------------------ > > Key: HADOOP-17618 > URL: https://issues.apache.org/jira/browse/HADOOP-17618 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/azure > Affects Versions: 3.3.1 > Reporter: Sumangala Patki > Assignee: Sumangala Patki > Priority: Major > Labels: pull-request-available > Time Spent: 5h 50m > Remaining Estimate: 0h > > Delegation SAS tokens are created using various parameters for specifying > details such as permissions and validity. The requests are logged, along with > values of all the query parameters. This change will partially mask values > logged for the following object IDs representing the security principal: > skoid, saoid, suoid -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org