[GitHub] [hadoop] tomscut commented on pull request #2933: HDFS-15991. Add location into datanode info for NameNodeMXBean

[GitBox]

tomscut commented on pull request #2933:
URL: https://github.com/apache/hadoop/pull/2933#issuecomment-825641497


   > > @tomscut Thanks for working on this. It makes sense to me. Some comments,
   > > 
   > > * Could you add unit tests? We may want to edit TestNameNodeMXBean.
   > > * Router WebUI uses the location information. Could you do the same for 
NameNode WebUI?
   > > 
   > > Router WebUI (federationhealth.html)
   > > 
![image](https://user-images.githubusercontent.com/11712443/115539064-7d5f5480-a2d7-11eb-97a0-78adb80a2158.png)
   > > NameNode WebUI (dfshealth.html)
   > > 
![image](https://user-images.githubusercontent.com/11712443/115539120-90722480-a2d7-11eb-8150-258d0ff5ac91.png)
   > 
   > Thanks @tasanuma for your review and comment. I'll refine that ASAP.
   
   Hi @tasanuma , I fix this problem. IMO, the NameNode UI does not need to 
show NS. What do you think?
   
   
![image](https://user-images.githubusercontent.com/55134131/115873703-d369fe80-a475-11eb-8dfe-71e9348893d1.png)
   
   
![image](https://user-images.githubusercontent.com/55134131/115874297-80dd1200-a476-11eb-9531-a140b03072f7.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org