amahussein commented on pull request #2631: URL: https://github.com/apache/hadoop/pull/2631#issuecomment-827562798
> `Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized access at LdapGroupsMapping.java:[line 596]` > Was this caused by this PR or was it already there before/ I think this PR added `public Set<String> getGroupsSet(String user)` in line [LdapGroupsMapping#627](https://github.com/apache/hadoop/pull/2631/files#diff-34cbaed59eb28984bdb38185b850527c6bc2088d2295fee6657333084aeab668R627) that is not synchronized which in turn calls `doGetGroups()`. Perhaps this is why `findbugs` finds it a concurrency issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
