[ 
https://issues.apache.org/jira/browse/HADOOP-17673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17333199#comment-17333199
 ] 

Steve Loughran commented on HADOOP-17673:
-----------------------------------------

It was private/unstable until the IO stats change went in and it turned out 
that HBoss test builds broke. Which is why it's now limited private and the 
javadocs say "this is what you will break". We could make it unstable again.

I'm changing it again HADOOP-17511 as suddenty there's a lot to pass in. It'll 
become this:
{code}
  AmazonS3 createS3Client(URI uri,
      S3ClientCreationParameters parameters) throws IOException;
{code}

#. We could maybe move to the parameter object and mark as unstable now, so 
that at least there's less disruption when things change again.
# I'm now a believer in parameter objects for plugin points because it's 
possible to add new arguments without stopping linking



> IOStatistics API in branch-3.3 break compatibility
> --------------------------------------------------
>
>                 Key: HADOOP-17673
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17673
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Wei-Chiu Chuang
>            Priority: Critical
>
> The S3 delegation token feature (3.3.0) added APIĀ 
> {code:java}
>   AmazonS3 createS3Client(URI name,
>       String bucket,
>       AWSCredentialsProvider credentialSet,
>       String userAgentSuffix) throws IOException;
>  {code}
> However, the IOStatistics API (HADOOP-17271, HADOOP-13551. in 3.3.1) changed 
> it to
> {code:java}
>   AmazonS3 createS3Client(URI name,
>       String bucket,
>       AWSCredentialsProvider credentialSet,
>       String userAgentSuffix) throws IOException; {code}
> The API is declared evolving, so we're not supposed to break compat between 
> maintenance releases.
> [~ste...@apache.org]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to