[ 
https://issues.apache.org/jira/browse/HADOOP-17702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346048#comment-17346048
 ] 

Steve Loughran commented on HADOOP-17702:
-----------------------------------------

Thanks for spotting this (automatically?)

I don't think we should be tagging this as @public, because its an internal 
component to the ABFS filesystem. That itself is only tagged as 
@InterfaceStability.Evolving ; no @Public at all, because the expectation there 
is that it is only constructed (outside of abfs tests) through 
FileSystem.get(). The {{AzureBlobFileSystemStore}} class should have visibility 
even lower than that, shouldn't it?

Proposed: remove the @Public attribute

> HADOOP-17065 breaks compatibility between 3.3.0 and 3.3.1
> ---------------------------------------------------------
>
>                 Key: HADOOP-17702
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17702
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/azure
>    Affects Versions: 3.3.1
>            Reporter: Wei-Chiu Chuang
>            Priority: Blocker
>
> AzureBlobFileSystemStore is a Public, Evolving class, by contract can't break 
> compatibility between maintenance releases.
> HADOOP-17065 changed its constructor signature from 
> {noformat}
>   public AzureBlobFileSystemStore(URI uri, boolean isSecureScheme,
>                                   Configuration configuration,
>                                   AbfsCounters abfsCounters) throws 
> IOException {
> {noformat}
> to
> {noformat}
>   public AzureBlobFileSystemStore(URI uri, boolean isSecureScheme,
>                                   Configuration configuration,
>                                   AbfsCounters abfsCounters) throws 
> IOException {
> {noformat}
> between 3.3.0 and 3.3.1.
> cc: [~mehakmeetSingh], [~tmarquardt]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to