[
https://issues.apache.org/jira/browse/HADOOP-17704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17346535#comment-17346535
]
Thomas Marqardt commented on HADOOP-17704:
------------------------------------------
It's unfortunate that an error was made and HADOOP-16730 was committed in 3.3.0
instead of 3.3.1.
The SASTokenProvider interface and implementation was a collaboration between
Microsoft and Cloudera, and CDP has a dependency on the latest version of the
SASTokenProvider interface (not the initial one). The interface is attributed
with @InterfaceStability.Unstable, and other than CDP I'm not aware of it being
used. The Apache Ranger source code does not use this interface, as far as I
can tell, probably the source used by CDP has not yet been shared with the
community. Also, prior to HADOOP-16916 the implementation had a few issues, so
it is extremely unlikely that anyone took a dependency. You pointed out the
interface change in this JIRA, but the underlying implementation was also
changed in HADOOP-16916. Attempting to fix the breaking change would be quite
ugly, resulting in two underlying code paths, two interfaces (SASTokenProvider
and SASTokenProvider2), and two sets of tests. Since CDP needs the latest and
I'm not aware of anyone else using this, I think the risk of breaking users is
very, very low and we should not consider this a blocker for 3.3.1, but instead
leave it as-is and resolve this JIRA.
> HADOOP-16916 changed interface SASTokenProvider fields, breaking
> compatibility between 3.3.0 and 3.3.1
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-17704
> URL: https://issues.apache.org/jira/browse/HADOOP-17704
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure
> Affects Versions: 3.3.1
> Reporter: Wei-Chiu Chuang
> Priority: Blocker
>
> I understand HADOOP-16730/HADOOP-16916 is specifically made for Ranger, but I
> am not sure how Ranger consumes this feature. The interface SASTokenProvider
> has a number of member fields that changed variable names in HADOOP-16916,
> breaking the compatibility between 3.3.0 and 3.3.1.
> As a matter of fact, the feature HADOOP-16730 itself was merged in 3.3.0 not
> 3.3.1. I just corrected it today.
> Raise this jira and mark it as a blocker for 3.3.1. But if this isn't a big
> deal then we can downgrade, because, well, this feature was not officially in
> the 3.3.0 release.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
