jojochuang commented on a change in pull request #3016:
URL: https://github.com/apache/hadoop/pull/3016#discussion_r634023560
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/SSLFactory.java
##########
@@ -99,7 +101,13 @@
public static final String SSL_SERVER_EXCLUDE_CIPHER_LIST =
"ssl.server.exclude.cipher.list";
- public static final String SSLCERTIFICATE = IBM_JAVA?"ibmX509":"SunX509";
+ public static final String KEY_MANAGER_SSLCERTIFICATE =
Review comment:
we removed a public static final variable here. Search at Apache github,
no Apache project use Hadoop's SSLFactory. SSLCERTIFICATE, so we're probably
fine here.
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/TestSSLFactory.java
##########
@@ -367,6 +369,20 @@ public void invalidHostnameVerifier() throws Exception {
}
}
+ @Test
+ public void testDifferentAlgorithm() throws Exception {
+ Configuration conf = createConfiguration(false, true);
+ String currAlg = getProperty("ssl.KeyManagerFactory.algorithm");
Review comment:
The property is used by JDK API KeyManagerFactory#getDefaultAlgorithm()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
