[ https://issues.apache.org/jira/browse/HADOOP-17590?focusedWorklogId=605107&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-605107 ]
ASF GitHub Bot logged work on HADOOP-17590: ------------------------------------------- Author: ASF GitHub Bot Created on: 02/Jun/21 10:49 Start Date: 02/Jun/21 10:49 Worklog Time Spent: 10m Work Description: snvijaya commented on a change in pull request #3026: URL: https://github.com/apache/hadoop/pull/3026#discussion_r643843222 ########## File path: hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java ########## @@ -326,4 +345,37 @@ private void incrementCounter(AbfsStatistic statistic, long value) { abfsCounters.incrementCounter(statistic, value); } } + + private void updateRequestHeaders() { Review comment: AbfsRestOperation is not supposed to have any API specific implementations or handling. Come up with a LeaseRetryPolicy that will be used when executing operations that pass in leaseId. That can control retry count to 2 or how many ever reduced number of retries needed. Post that, if the request still fails, retry policy should exit AbfsRestOperation and abfsClient should take care of retrying from the respective method post updating request headers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 605107) Time Spent: 2h 20m (was: 2h 10m) > ABFS: Introduce Lease Operations with Append to provide single writer > semantics > ------------------------------------------------------------------------------- > > Key: HADOOP-17590 > URL: https://issues.apache.org/jira/browse/HADOOP-17590 > Project: Hadoop Common > Issue Type: Sub-task > Reporter: Sneha Varma > Assignee: Sneha Varma > Priority: Major > Labels: pull-request-available > Time Spent: 2h 20m > Remaining Estimate: 0h > > The lease operations will be introduced as part of Append, Flush to ensure > the single writer semantics. > > Details: > Acquire Lease will be introduced in Create, Auto-Renew, Acquire will be added > to Append & Release, Auto-Renew, Acquire in Flush. > > Duration the creation of the file the lease will be acquired, as part of > appends the lease will be auto-renewed & the lease can be released as part of > flush. > > By default the lease duration will be of 60 seconds. > "fs.azure.write.enforcelease" & "fs.azure.write.lease.duration" two configs > will be introduced. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org