base111 commented on a change in pull request #3086: URL: https://github.com/apache/hadoop/pull/3086#discussion_r650119510
########## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/metrics/RBFMetrics.java ########## @@ -165,11 +172,46 @@ public RBFMetrics(Router router) throws IOException { // Initialize the cache for the DN reports Configuration conf = router.getConfig(); - this.timeOut = conf.getTimeDuration(RBFConfigKeys.DN_REPORT_TIME_OUT, - RBFConfigKeys.DN_REPORT_TIME_OUT_MS_DEFAULT, TimeUnit.MILLISECONDS); this.topTokenRealOwners = conf.getInt( RBFConfigKeys.DFS_ROUTER_METRICS_TOP_NUM_TOKEN_OWNERS_KEY, RBFConfigKeys.DFS_ROUTER_METRICS_TOP_NUM_TOKEN_OWNERS_KEY_DEFAULT); + // Initialize the cache for the DN reports + this.dnReportTimeOut = conf.getTimeDuration( + RBFConfigKeys.DN_REPORT_TIME_OUT, + RBFConfigKeys.DN_REPORT_TIME_OUT_MS_DEFAULT, TimeUnit.MILLISECONDS); + long dnCacheExpire = conf.getTimeDuration( + RBFConfigKeys.DN_REPORT_CACHE_EXPIRE, + RBFConfigKeys.DN_REPORT_CACHE_EXPIRE_MS_DEFAULT, TimeUnit.MILLISECONDS); + this.dnCache = CacheBuilder.newBuilder() Review comment: Yes,They should use the same dncache. In addition, I want to extract NamesystemMetrics and NameNodeInfoMetrics into RBFMetrics. I don't think they should be serialized to StateStore and then de-serialized to be used by RBFMetrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org