[
https://issues.apache.org/jira/browse/HADOOP-17769?focusedWorklogId=613049&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-613049
]
ASF GitHub Bot logged work on HADOOP-17769:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/21 07:42
Start Date: 22/Jun/21 07:42
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3131:
URL: https://github.com/apache/hadoop/pull/3131#issuecomment-865312114
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 16m 9s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ branch-2.10 Compile Tests _ |
| +0 :ok: | mvndep | 2m 19s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 13m 15s | branch-2.10 passed |
| +1 :green_heart: | compile | 14m 2s | branch-2.10 passed with JDK
Azul Systems, Inc.-1.7.0_262-b10 |
| +1 :green_heart: | compile | 12m 1s | branch-2.10 passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| +1 :green_heart: | mvnsite | 2m 3s | branch-2.10 passed |
| +1 :green_heart: | javadoc | 1m 41s | branch-2.10 passed with JDK
Azul Systems, Inc.-1.7.0_262-b10 |
| +1 :green_heart: | javadoc | 1m 29s | branch-2.10 passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 19s | the patch passed |
| +1 :green_heart: | compile | 13m 26s | the patch passed with JDK Azul
Systems, Inc.-1.7.0_262-b10 |
| +1 :green_heart: | javac | 13m 26s | the patch passed |
| +1 :green_heart: | compile | 12m 1s | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| +1 :green_heart: | javac | 12m 1s | the patch passed |
| +1 :green_heart: | mvnsite | 2m 1s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 1m 41s | the patch passed with JDK Azul
Systems, Inc.-1.7.0_262-b10 |
| +1 :green_heart: | javadoc | 1m 31s | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 19s | hadoop-project in the patch
passed. |
| +1 :green_heart: | unit | 1m 11s | hadoop-yarn-server-timelineservice
in the patch passed. |
| +1 :green_heart: | unit | 0m 30s |
hadoop-yarn-server-timelineservice-hbase-client in the patch passed. |
| +1 :green_heart: | unit | 7m 32s |
hadoop-yarn-server-timelineservice-hbase-tests in the patch passed. |
| +1 :green_heart: | asflicense | 0m 43s | The patch does not generate
ASF License warnings. |
| | | 110m 2s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3131/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3131 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml |
| uname | Linux 6b5a3c950908 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28
05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-2.10 / ab6b568 |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| Multi-JDK versions | /usr/lib/jvm/zulu-7-amd64:Azul Systems,
Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3131/1/testReport/ |
| Max. process+thread count | 732 (vs. ulimit of 5500) |
| modules | C: hadoop-project
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-client
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3131/1/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 613049)
Time Spent: 50m (was: 40m)
> Upgrade JUnit to 4.13.2
> -----------------------
>
> Key: HADOOP-17769
> URL: https://issues.apache.org/jira/browse/HADOOP-17769
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.3.1, 3.4.0, 2.10.2, 3.2.3
> Reporter: Ahmed Hussein
> Assignee: Ahmed Hussein
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> JUnit 4.13.1 has a bug that is reported in Junit
> [issue-1652|https://github.com/junit-team/junit4/issues/1652] _Timeout
> ThreadGroups should not be destroyed_
> After upgrading Junit to 4.13.1 in HADOOP-17602, {{TestBlockRecovery}}
> started to fail regularly in branch-3.x and branch-2.10.
> While investigating the failure in branch-2.10 HDFS-16072, I found out that
> the bug is the main reason {{TestBlockRecovery}} started to fail because the
> timeout of the Junit would try to close a ThreadGroup that has been already
> closed which throws the {{java.lang.IllegalThreadStateException}}.
> The bug has been fixed in Junit-4.13.2
> For branch-3.x, HDFS-15940 did not address the root cause of the problem.
> Eventually, Splitting the {{TestBlockRecovery}} hid the bug, but the upgrade
> needs to be done so that the problem does not show up in another unit test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
