goiri commented on a change in pull request #3151:
URL: https://github.com/apache/hadoop/pull/3151#discussion_r659916854
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/tests/configuration_test.cc
##########
@@ -19,6 +19,7 @@
#include "configuration_test.h"
#include "common/configuration.h"
#include "common/configuration_loader.h"
+
Review comment:
Is this just to trigger the tests? Undo?
##########
File path: dev-support/Jenkinsfile
##########
@@ -56,6 +56,34 @@ pipeline {
}
}
+ // This is an optional stage which runs only when there's a change in
+ // C++/C++ build/platform.
+ // This stage serves as a means of cross platform validation, which is
+ // really needed to ensure that any C++ related/platform change doesn't
+ // break the Hadoop build on Centos 8.
+ stage ('precommit-run Centos 8') {
+ environment {
+ DOCKERFILE =
"${SOURCEDIR}/dev-support/docker/Dockerfile_centos_8"
+ IS_OPTIONAL = 1
+ }
+
+ steps {
+ withCredentials(
+ [usernamePassword(credentialsId:
'apache-hadoop-at-github.com',
Review comment:
This is now repeating 3 times in this file, can we reuse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
