shvachko commented on pull request #2260:
URL: https://github.com/apache/hadoop/pull/2260#issuecomment-872643068
Looks good generally. I checked the tests are catching previous errors.
- There seems to be one last checkstyle warning.
- Also I see you use {{import static org.junit.Assert.*;}} and
{{viewfs.Constants.*;}} We should import only what is actually needed. Avoid
*-imports.
- And I found an empty line added in {{ViewFileSystem}}. Don't know why
checkstyle didn't catch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
