[ https://issues.apache.org/jira/browse/HADOOP-17028?focusedWorklogId=617936&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617936 ]
ASF GitHub Bot logged work on HADOOP-17028: ------------------------------------------- Author: ASF GitHub Bot Created on: 02/Jul/21 01:11 Start Date: 02/Jul/21 01:11 Worklog Time Spent: 10m Work Description: shvachko commented on pull request #2260: URL: https://github.com/apache/hadoop/pull/2260#issuecomment-872643068 Looks good generally. I checked the tests are catching previous errors. - There seems to be one last checkstyle warning. - Also I see you use {{import static org.junit.Assert.*;}} and {{viewfs.Constants.*;}} We should import only what is actually needed. Avoid *-imports. - And I found an empty line added in {{ViewFileSystem}}. Don't know why checkstyle didn't catch it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 617936) Time Spent: 6h 10m (was: 6h) > ViewFS should initialize target filesystems lazily > -------------------------------------------------- > > Key: HADOOP-17028 > URL: https://issues.apache.org/jira/browse/HADOOP-17028 > Project: Hadoop Common > Issue Type: Bug > Components: client-mounts, fs, viewfs > Affects Versions: 3.2.1 > Reporter: Uma Maheswara Rao G > Assignee: Abhishek Das > Priority: Major > Labels: pull-request-available > Time Spent: 6h 10m > Remaining Estimate: 0h > > Currently viewFS initialize all configured target filesystems when > viewfs#init itself. > Some target file system initialization involve creating heavy objects and > proxy connections. Ex: DistributedFileSystem#initialize will create DFSClient > object which will create proxy connections to NN etc. > For example: if ViewFS configured with 10 target fs with hdfs uri and 2 > targets with s3a. > If one of the client only work with s3a target, But ViewFS will initialize > all targets irrespective of what clients interested to work with. That means, > here client will create 10 DFS initializations and 2 s3a initializations. Its > unnecessary to have DFS initialization here. So, it will be a good idea to > initialize the target fs only when first time usage call come to particular > target fs scheme. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org