steveloughran commented on a change in pull request #3153:
URL: https://github.com/apache/hadoop/pull/3153#discussion_r666930271
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsIntegrationTest.java
##########
@@ -443,6 +445,16 @@ protected Path path(String filepath) throws IOException {
new Path(getTestPath(), filepath));
}
+ /**
+ * Generate a unique path using the given filepath
Review comment:
nit: add .
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemOauth.java
##########
@@ -90,29 +92,29 @@ public void testBlobDataContributor() throws Exception {
// Verify Blob Data Contributor has full access to existed folder, file
// READ FOLDER
- assertTrue(fs.exists(EXISTED_FOLDER_PATH));
+ assertTrue(fs.exists(existedFolderPath));
//DELETE FOLDER
- fs.delete(EXISTED_FOLDER_PATH, true);
- assertFalse(fs.exists(EXISTED_FOLDER_PATH));
+ fs.delete(existedFolderPath, true);
+ assertFalse(fs.exists(existedFolderPath));
Review comment:
good time to move to the ContractTestUtils assertions
assertPathExists/assertPathDoesNotExist as they provide meaningful
messages/diagnostics. I really don't like assertTrue/assertFalse without
messages, as they make debugging test failures much harder than they need to be
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
