sumangala-patki commented on a change in pull request #2975:
URL: https://github.com/apache/hadoop/pull/2975#discussion_r669170174
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystem.java
##########
@@ -204,38 +205,51 @@ public void registerListener(Listener listener1) {
public FSDataInputStream open(final Path path, final int bufferSize) throws
IOException {
LOG.debug("AzureBlobFileSystem.open path: {} bufferSize: {}", path,
bufferSize);
// bufferSize is unused.
- return open(path, Optional.empty());
+ return open(path, new OpenFileParameters());
}
private FSDataInputStream open(final Path path,
- final Optional<Configuration> options) throws IOException {
+ final OpenFileParameters parameters) throws IOException {
statIncrement(CALL_OPEN);
Path qualifiedPath = makeQualified(path);
try {
TracingContext tracingContext = new TracingContext(clientCorrelationId,
- fileSystemId, FSOperationType.OPEN, tracingHeaderFormat,
- listener);
- InputStream inputStream = abfsStore.openFileForRead(qualifiedPath,
- options, statistics, tracingContext);
+ fileSystemId, FSOperationType.OPEN, tracingHeaderFormat, listener);
+ InputStream inputStream = abfsStore
+ .openFileForRead(qualifiedPath, parameters, statistics,
+ tracingContext);
return new FSDataInputStream(inputStream);
} catch(AzureBlobFileSystemException ex) {
checkException(path, ex);
return null;
}
}
+ /**
+ * Takes config and other options through
+ * {@link org.apache.hadoop.fs.impl.OpenFileParameters}. Ensure that
+ * FileStatus entered is up-to-date, as it will be used to create the
+ * InputStream (with info such as contentLength, eTag)
+ * @param path The location of file to be opened
+ * @param parameters OpenFileParameters instance; can hold FileStatus,
+ * Configuration, bufferSize and mandatoryKeys
+ */
@Override
- protected CompletableFuture<FSDataInputStream> openFileWithOptions(
- final Path path, final OpenFileParameters parameters) throws IOException
{
+ public CompletableFuture<FSDataInputStream> openFileWithOptions(
Review comment:
changed to protected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
