[
https://issues.apache.org/jira/browse/HADOOP-17542?focusedWorklogId=633628&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633628
]
ASF GitHub Bot logged work on HADOOP-17542:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/21 14:58
Start Date: 04/Aug/21 14:58
Worklog Time Spent: 10m
Work Description: brahmareddybattula commented on a change in pull
request #3217:
URL: https://github.com/apache/hadoop/pull/3217#discussion_r682650919
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
##########
@@ -199,8 +199,14 @@ public Path(String pathString) throws
IllegalArgumentException {
int start = 0;
// parse uri scheme, if any
- int colon = pathString.indexOf(':');
- int slash = pathString.indexOf('/');
+ int colon = -1;
+ int slash = -1;
Review comment:
I think, we no need to declare slash as this we dn't change.
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/Path.java
##########
@@ -199,8 +199,14 @@ public Path(String pathString) throws
IllegalArgumentException {
int start = 0;
// parse uri scheme, if any
- int colon = pathString.indexOf(':');
- int slash = pathString.indexOf('/');
+ int colon = -1;
+ int slash = -1;
+ if (StringUtils.countMatches(pathString, ":") > 2) {
Review comment:
May be we can comment this, why we have doe like this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 633628)
Time Spent: 1h 50m (was: 1h 40m)
> IPV6 support in Netutils#createSocketAddress
> ---------------------------------------------
>
> Key: HADOOP-17542
> URL: https://issues.apache.org/jira/browse/HADOOP-17542
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 3.1.1
> Reporter: ANANDA G B
> Assignee: Renukaprasad C
> Priority: Minor
> Labels: ipv6, pull-request-available
> Attachments: HADOOP-17542-HADOOP-11890-001.patch, Test Scenarios
> Verified in IPV6 cluster.doc
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently NetUtils#createSocketAddress not supporting if target is IPV6 ip.
> If target is IPV6 ip then it throw "Does not contain a valid host:port
> authority: ".
> This need be support.
> public static InetSocketAddress createSocketAddr(String target,
> int defaultPort,
> String configName,
> boolean useCacheIfPresent) {
> String helpText = "";
> if (configName != null)
> { helpText = " (configuration property '" + configName + "')"; }
> if (target == null)
> { throw new IllegalArgumentException("Target address cannot be null." +
> helpText); }
> target = target.trim();
> boolean hasScheme = target.contains("://");
> URI uri = createURI(target, hasScheme, helpText, useCacheIfPresent);
> String host = uri.getHost();
> int port = uri.getPort();
> if (port == -1)
> { port = defaultPort; }
> String path = uri.getPath();
> if ((host == null) || (port < 0) ||
> (!hasScheme && path != null && !path.isEmpty()))
> { throw new IllegalArgumentException( *"Does not contain a valid host:port
> authority: " + target + helpText* ); }
> return createSocketAddrForHost(host, port);
> }
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
