sodonnel commented on a change in pull request #3269:
URL: https://github.com/apache/hadoop/pull/3269#discussion_r683390561
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java
##########
@@ -618,9 +620,10 @@ private void selectStreamingInputStreams(
Map<AsyncLogger, RemoteEditLogManifest> resps =
loggers.waitForWriteQuorum(q, selectInputStreamsTimeoutMs,
"selectStreamingInputStreams");
-
- LOG.debug("selectStreamingInputStream manifests:\n" +
- Joiner.on("\n").withKeyValueSeparator(": ").join(resps));
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("selectStreamingInputStream manifests:\n" +
+ Joiner.on("\n").withKeyValueSeparator(": ").join(resps));
+ }
Review comment:
In this case, I don't think there is a simple way to avoid the
evaluation without the `if (LOG.isDebugEnabled())`, so this one is good,
however can still change it to:
```
LOG.debug("selectStreamingInputStream manifests:\n {}",
Joiner.on("\n").withKeyValueSeparator(": ").join(resps));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
