[
https://issues.apache.org/jira/browse/HADOOP-15327?focusedWorklogId=635082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635082
]
ASF GitHub Bot logged work on HADOOP-15327:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/21 11:42
Start Date: 06/Aug/21 11:42
Worklog Time Spent: 10m
Work Description: szilard-nemeth commented on a change in pull request
#3259:
URL: https://github.com/apache/hadoop/pull/3259#discussion_r684169065
##########
File path:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/LoggingHttpResponseEncoder.java
##########
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.mapred;
+
+import io.netty.buffer.ByteBuf;
+import io.netty.channel.ChannelHandlerContext;
+import io.netty.channel.ChannelPromise;
+import io.netty.handler.codec.http.HttpHeaders;
+import io.netty.handler.codec.http.HttpResponse;
+import io.netty.handler.codec.http.HttpResponseEncoder;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+
+class LoggingHttpResponseEncoder extends HttpResponseEncoder {
+ private static final Logger LOG =
LoggerFactory.getLogger(LoggingHttpResponseEncoder.class);
+ private final boolean logStacktraceOfEncodingMethods;
+
+ public LoggingHttpResponseEncoder(boolean logStacktraceOfEncodingMethods) {
+ this.logStacktraceOfEncodingMethods = logStacktraceOfEncodingMethods;
+ }
+
+ @Override
+ public boolean acceptOutboundMessage(Object msg) throws Exception {
+ printExecutingMethod();
+ LOG.info("OUTBOUND MESSAGE: " + msg);
+ return super.acceptOutboundMessage(msg);
+ }
+
+ @Override
+ protected void encodeInitialLine(ByteBuf buf, HttpResponse response) throws
Exception {
+ LOG.debug("Executing method: {}, response: {}",
+ getExecutingMethodName(), response);
+ logStacktraceIfRequired();
+ super.encodeInitialLine(buf, response);
+ }
+
+ @Override
+ protected void encode(ChannelHandlerContext ctx, Object msg,
+ List<Object> out) throws Exception {
+ LOG.debug("Encoding to channel {}: {}", ctx.channel(), msg);
+ printExecutingMethod();
+ logStacktraceIfRequired();
+ super.encode(ctx, msg, out);
+ }
+
+ @Override
+ protected void encodeHeaders(HttpHeaders headers, ByteBuf buf) {
+ printExecutingMethod();
+ super.encodeHeaders(headers, buf);
+ }
+
+ @Override
+ public void write(ChannelHandlerContext ctx, Object msg, ChannelPromise
+ promise) throws Exception {
+ LOG.debug("Writing to channel {}: {}", ctx.channel(), msg);
+ printExecutingMethod();
+ super.write(ctx, msg, promise);
+ }
+
+ private void logStacktraceIfRequired() {
+ if (logStacktraceOfEncodingMethods) {
+ LOG.debug("Stacktrace: ", new Throwable());
+ }
+ }
+
+ private void printExecutingMethod() {
+ String methodName = getExecutingMethodName();
+ LOG.debug("Executing method: {}", methodName);
+ }
+
+ private String getExecutingMethodName() {
+ try {
+ StackTraceElement[] stackTrace = Thread.currentThread()
+ .getStackTrace();
+ // Array items (indices):
+ // 0: java.lang.Thread.getStackTrace(...)
+ // 1: TestShuffleHandler$LoggingHttpResponseEncoder
+ // .getExecutingMethodName(...)
+ String methodName = stackTrace[2].getMethodName();
+ //If this method was called from printExecutingMethod,
+ // we have yet another stack frame
+ if (methodName.endsWith("printExecutingMethod")) {
+ methodName = stackTrace[3].getMethodName();
+ }
+ String className = this.getClass().getSimpleName();
+ return className + "#" + methodName;
+ } catch (Throwable t) {
+ LOG.error("Error while getting execution method name", t);
+ return null;
Review comment:
This makes sense as well, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 635082)
Time Spent: 1h 10m (was: 1h)
> Upgrade MR ShuffleHandler to use Netty4
> ---------------------------------------
>
> Key: HADOOP-15327
> URL: https://issues.apache.org/jira/browse/HADOOP-15327
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Szilard Nemeth
> Priority: Major
> Labels: pull-request-available
> Attachments: HADOOP-15327.001.patch, HADOOP-15327.002.patch,
> HADOOP-15327.003.patch, HADOOP-15327.004.patch, HADOOP-15327.005.patch,
> HADOOP-15327.005.patch,
> getMapOutputInfo_BlockingOperationException_awaitUninterruptibly.log,
> testfailure-testMapFileAccess-emptyresponse.zip,
> testfailure-testReduceFromPartialMem.zip
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This way, we can remove the dependencies on the netty3 (jboss.netty)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
