[ 
https://issues.apache.org/jira/browse/HADOOP-17198?focusedWorklogId=635100&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635100
 ]

ASF GitHub Bot logged work on HADOOP-17198:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Aug/21 12:16
            Start Date: 06/Aug/21 12:16
    Worklog Time Spent: 10m 
      Work Description: mehakmeet commented on a change in pull request #3260:
URL: https://github.com/apache/hadoop/pull/3260#discussion_r684186895



##########
File path: 
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -822,10 +854,21 @@ private void bindAWSClient(URI name, boolean dtEnabled) 
throws IOException {
         S3_CLIENT_FACTORY_IMPL, DEFAULT_S3_CLIENT_FACTORY_IMPL,
         S3ClientFactory.class);
 
+    // If there's no endpoint set, then use the default for bucket or 
AccessPoint. Overriding is
+    // useful when using FIPS or DualStack S3 endpoints.
+    String endpoint = conf.getTrimmed(ENDPOINT, "");
+    if (endpoint.isEmpty()) {

Review comment:
       So, basically, if we have an Accesspoint set, we can't have an endpoint 
set as well? or we would have to change something like 
`s3.ap-south-1.amazonaws.com` to `s3-accesspoint.ap-south-1.amazonaws.com`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 635100)
    Time Spent: 5h  (was: 4h 50m)

> Support S3 Access Points
> ------------------------
>
>                 Key: HADOOP-17198
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17198
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.3.0
>            Reporter: Steve Loughran
>            Assignee: Bogdan Stolojan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 5h
>  Remaining Estimate: 0h
>
> Improve VPC integration by supporting access points for buckets
> https://docs.aws.amazon.com/AmazonS3/latest/dev/access-points.html
> Not sure how to do this *at all*; 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to