[
https://issues.apache.org/jira/browse/HADOOP-15327?focusedWorklogId=635158&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635158
]
ASF GitHub Bot logged work on HADOOP-15327:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/21 13:52
Start Date: 06/Aug/21 13:52
Worklog Time Spent: 10m
Work Description: szilard-nemeth commented on a change in pull request
#3259:
URL: https://github.com/apache/hadoop/pull/3259#discussion_r684253185
##########
File path:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/test/java/org/apache/hadoop/mapred/TestShuffleHandler.java
##########
@@ -204,6 +828,34 @@ protected boolean isSocketKeepAlive() {
}
}
+ @Rule
+ public TestName name = new TestName();
+
+ @Before
+ public void setup() {
+ TEST_EXECUTION = new TestExecution(DEBUG_MODE, USE_PROXY);
+ }
+
+ @After
+ public void tearDown() {
+ int port = TEST_EXECUTION.shuffleHandlerPort();
+ if (isPortUsed(port)) {
+ String msg = String.format("Port is being used: %d. " +
+ "Current testcase name: %s",
+ port, name.getMethodName());
+ throw new IllegalStateException(msg);
+ }
+ }
+
+ private static boolean isPortUsed(int port) {
+ try (Socket ignored = new Socket("localhost", port)) {
+ return true;
+ } catch (IOException e) {
+ LOG.error("Port: {}, port check result: {}", port, e.getMessage());
+ return false;
+ }
+ }
+
Review comment:
Good point, added explicit check for port=0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 635158)
Time Spent: 4h 40m (was: 4.5h)
> Upgrade MR ShuffleHandler to use Netty4
> ---------------------------------------
>
> Key: HADOOP-15327
> URL: https://issues.apache.org/jira/browse/HADOOP-15327
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Szilard Nemeth
> Priority: Major
> Labels: pull-request-available
> Attachments: HADOOP-15327.001.patch, HADOOP-15327.002.patch,
> HADOOP-15327.003.patch, HADOOP-15327.004.patch, HADOOP-15327.005.patch,
> HADOOP-15327.005.patch,
> getMapOutputInfo_BlockingOperationException_awaitUninterruptibly.log,
> testfailure-testMapFileAccess-emptyresponse.zip,
> testfailure-testReduceFromPartialMem.zip
>
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> This way, we can remove the dependencies on the netty3 (jboss.netty)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
