tomscut commented on a change in pull request #3354: URL: https://github.com/apache/hadoop/pull/3354#discussion_r701514329
########## File path: hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/DatanodeID.java ########## @@ -255,6 +255,13 @@ public int getXferPort() { return xferPort; } + /** + * @return name useful for logging or display + */ + public String getDisplayName() { Review comment: > `DatanodeID#getXferAddrWithHostname()` is the same method, isn't it? Thank you for reminding me that the two methods are indeed the same. I will make some change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org