[ 
https://issues.apache.org/jira/browse/HADOOP-17887?focusedWorklogId=646136&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646136
 ]

ASF GitHub Bot logged work on HADOOP-17887:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Sep/21 01:46
            Start Date: 03/Sep/21 01:46
    Worklog Time Spent: 10m 
      Work Description: viirya commented on a change in pull request #3377:
URL: https://github.com/apache/hadoop/pull/3377#discussion_r701528741



##########
File path: 
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipCompressor.java
##########
@@ -86,10 +86,6 @@ public int compress(byte[] b, int off, int len) throws 
IOException {
 
     int compressedBytesWritten = 0;
 
-    if (currentBufLen <= 0) {
-      return compressedBytesWritten;
-    }
-

Review comment:
       Also, found this bug. If we set an empty input to the compress stream, 
it will cause endless loop.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 646136)
    Time Spent: 20m  (was: 10m)

> Remove GzipOutputStream
> -----------------------
>
>                 Key: HADOOP-17887
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17887
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: L. C. Hsieh
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> As we provide built-in gzip compressor, we can use it in compressor stream. 
> The wrapper GzipOutputStream can be removed now.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to