sunchao commented on a change in pull request #3377: URL: https://github.com/apache/hadoop/pull/3377#discussion_r702016242
########## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/compress/zlib/BuiltInGzipCompressor.java ########## @@ -86,10 +86,6 @@ public int compress(byte[] b, int off, int len) throws IOException { int compressedBytesWritten = 0; - if (currentBufLen <= 0) { - return compressedBytesWritten; - } - Review comment: Which test is failing before removing the condition? so it passes with the wrapper class but fails after? Also, we can remove the `currentBufLen` variable now since it is no longer used anywhere else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org