[
https://issues.apache.org/jira/browse/HADOOP-17892?focusedWorklogId=649998&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649998
]
ASF GitHub Bot logged work on HADOOP-17892:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/21 13:02
Start Date: 13/Sep/21 13:02
Worklog Time Spent: 10m
Work Description: virajjasani commented on a change in pull request #3387:
URL: https://github.com/apache/hadoop/pull/3387#discussion_r707312230
##########
File path: dev-support/code-formatter/hadoop_idea_formatter.xml
##########
@@ -0,0 +1,76 @@
+<!--
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+-->
+<code_scheme name="Hadoop" version="173">
+ <option name="RIGHT_MARGIN" value="80" />
+ <JavaCodeStyleSettings>
+ <option name="CLASS_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />
+ <option name="NAMES_COUNT_TO_USE_IMPORT_ON_DEMAND" value="999" />
+ <option name="PACKAGES_TO_USE_IMPORT_ON_DEMAND">
+ <value />
+ </option>
+ <option name="IMPORT_LAYOUT_TABLE">
+ <value>
+ <package name="org.apache.hadoop.thirdparty" withSubpackages="true"
static="false" />
+ <emptyLine />
+ <package name="" withSubpackages="true" static="false" />
+ <emptyLine />
+ <package name="javax" withSubpackages="true" static="false" />
+ <package name="java" withSubpackages="true" static="false" />
+ <emptyLine />
+ <package name="" withSubpackages="true" static="true" />
+ </value>
+ </option>
Review comment:
I tried to confirm from some of the oldest classes e.g Namenode and few
others (within namenode package). But now I see that some other similar old
classes have different order. For instance, Datanode itself has kind of reverse
order.
@steveloughran do we have the correct order defined somewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 649998)
Time Spent: 4h 40m (was: 4.5h)
> Add Hadoop code formatter in dev-support
> ----------------------------------------
>
> Key: HADOOP-17892
> URL: https://issues.apache.org/jira/browse/HADOOP-17892
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
> We should add Hadoop code formatter xml to dev-support specifically for new
> developers to refer to.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
