xkrogen commented on a change in pull request #3317:
URL: https://github.com/apache/hadoop/pull/3317#discussion_r707766429
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java
##########
@@ -52,11 +52,7 @@
MutableCounterLong bytesServedViaRpc;
@Metric
- MutableStat rpcRequestCacheMissAmount = new MutableStat(
- "RpcRequestCacheMissAmount", "Number of RPC requests unable to be " +
- "served due to lack of availability in cache, and how many " +
- "transactions away the request was from being in the cache.",
- "Misses", "Txns");
+ MutableStat rpcRequestCacheMissAmount;
Review comment:
If we explicitly instantiate the metric via `registry.newStat()`, then
we can remove the `@Metric` annotation. It's only necessary for metrics2 to
automatically create the metric for us. (It's been a while since I've looked at
Hadoop or metrics2, so let me know if I'm mis-remembering here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
