brumi1024 commented on a change in pull request #3418:
URL: https://github.com/apache/hadoop/pull/3418#discussion_r708384043
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java
##########
@@ -1571,99 +1588,98 @@ void
updateMaxAppRelatedField(CapacitySchedulerConfiguration conf,
.getMaximumCapacity(maxLabel));
}
- private void deriveCapacityFromAbsoluteConfigurations(String label,
- Resource clusterResource, ResourceCalculator rc) {
-
- /*
- * In case when queues are configured with absolute resources, it is better
- * to update capacity/max-capacity etc w.r.t absolute resource as well. In
- * case of computation, these values wont be used any more. However for
- * metrics and UI, its better these values are pre-computed here itself.
- */
-
- // 1. Update capacity as a float based on parent's minResource
- float f = rc.divide(clusterResource,
+ void deriveCapacityFromAbsoluteConfigurations(String label,
+ Resource clusterResource) {
+ // Update capacity with a float calculated from the parent's minResources
+ // and the recently changed queue minResources.
+ // capacity = effectiveMinResource / {parent's effectiveMinResource}
+ float result = resourceCalculator.divide(clusterResource,
queueResourceQuotas.getEffectiveMinResource(label),
parent.getQueueResourceQuotas().getEffectiveMinResource(label));
- queueCapacities.setCapacity(label, Float.isInfinite(f) ? 0 : f);
+ queueCapacities.setCapacity(label,
+ Float.isInfinite(result) ? 0 : result);
- // 2. Update max-capacity as a float based on parent's maxResource
- f = rc.divide(clusterResource,
+ // Update maxCapacity with a float calculated from the parent's
maxResources
+ // and the recently changed queue maxResources.
+ // maxCapacity = effectiveMaxResource / parent's effectiveMaxResource
+ result = resourceCalculator.divide(clusterResource,
queueResourceQuotas.getEffectiveMaxResource(label),
parent.getQueueResourceQuotas().getEffectiveMaxResource(label));
- queueCapacities.setMaximumCapacity(label, Float.isInfinite(f) ? 0 : f);
+ queueCapacities.setMaximumCapacity(label,
+ Float.isInfinite(result) ? 0 : result);
- // 3. Update absolute capacity as a float based on parent's minResource and
- // cluster resource.
+ // Update absolute capacity (as in fraction of the
+ // whole cluster's resources) with a float calculated from the queue's
+ // capacity and the parent's absoluteCapacity.
+ // absoluteCapacity = capacity * parent's absoluteCapacity
queueCapacities.setAbsoluteCapacity(label,
queueCapacities.getCapacity(label) * parent.getQueueCapacities()
.getAbsoluteCapacity(label));
- // 4. Update absolute max-capacity as a float based on parent's maxResource
- // and cluster resource.
+ // Update absolute maxCapacity (as in fraction of the
+ // whole cluster's resources) with a float calculated from the queue's
+ // maxCapacity and the parent's absoluteMaxCapacity.
+ // absoluteMaxCapacity = maxCapacity * parent's absoluteMaxCapacity
queueCapacities.setAbsoluteMaximumCapacity(label,
- queueCapacities.getMaximumCapacity(label) * parent.getQueueCapacities()
- .getAbsoluteMaximumCapacity(label));
+ queueCapacities.getMaximumCapacity(label) *
+ parent.getQueueCapacities()
+ .getAbsoluteMaximumCapacity(label));
}
void updateEffectiveResources(Resource clusterResource) {
for (String label : configuredNodeLabels) {
Resource resourceByLabel = labelManager.getResourceByLabel(label,
clusterResource);
-
Resource minResource = queueResourceQuotas.getConfiguredMinResource(
label);
+ Resource newEffectiveMinResource;
Review comment:
Actually in java it is not possible to declare a value in a block and
use it outside of that block. The value will be local to that block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
