szilard-nemeth commented on pull request #3430: URL: https://github.com/apache/hadoop/pull/3430#issuecomment-919383259
I don't get what the Spotbugs issue is about for the "VO_VOLATILE_INCREMENT" bug, as I'm updating the volatile field from synchroinzed methods only, which is enough to keep it thread-safe. For reference, here's the Spotbugs error reported: ``` Increment of volatile field org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueueUsageTracker.numContainers in org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueueUsageTracker.decreaseNumContainers() Bug type VO_VOLATILE_INCREMENT (click for details) In class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueueUsageTracker In method org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueueUsageTracker.decreaseNumContainers() Field org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueueUsageTracker.numContainers At AbstractCSQueueUsageTracker.java:[line 56] ``` Also, the unit test failure is a known flaky: "[ERROR] testAllocation[Duration 90,000,000, height 0.25, numSubmission 1, periodic 86400000)](org.apache.hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy) Time elapsed: 0.026 s <<< FAILURE!" - https://issues.apache.org/jira/browse/YARN-9450 - https://issues.apache.org/jira/browse/YARN-7548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
