jojochuang commented on a change in pull request #3491:
URL: https://github.com/apache/hadoop/pull/3491#discussion_r719145598
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/fs/XAttr.java
##########
@@ -158,6 +158,6 @@ public boolean equalsIgnoreValue(Object obj) {
@Override
public String toString() {
return "XAttr [ns=" + ns + ", name=" + name + ", value="
- + Arrays.toString(value) + "]";
+ + new String(value, Charset.defaultCharset()) + "]";
Review comment:
agreed, xattr is not necessarily printable. For example, encryption zone
file EDEK. To print, have we considered using XattrCodec APIs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
