afchung commented on a change in pull request #3642: URL: https://github.com/apache/hadoop/pull/3642#discussion_r746877782
########## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/AbstractYarnScheduler.java ########## @@ -720,7 +726,10 @@ public void completedContainer(RMContainer rmContainer, SchedulerApplicationAttempt schedulerAttempt = getCurrentAttemptForContainer(containerId); if (schedulerAttempt != null) { - schedulerAttempt.removeRMContainer(containerId); + if (schedulerAttempt.removeRMContainer(containerId)) { Review comment: Yes, it's in the else clause of `if (rmContainer.getExecutionType() == ExecutionType.GUARANTEED)`, where for now there's only one other type of `ExecutionType`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org