tomscut commented on a change in pull request #3731: URL: https://github.com/apache/hadoop/pull/3731#discussion_r758906333
########## File path: hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcServer.java ########## @@ -726,9 +726,10 @@ static String getMethodName() { * @return List of name spaces in the federation on * removing the already invoked namespaceinfo. */ - private Set<FederationNamespaceInfo> getNameSpaceInfo(String nsId) { + private Set<FederationNamespaceInfo> getNameSpaceInfo( Review comment: Thanks @goiri for your comment, I noticed that this method is currently only called in one place. So do we still need to change it to static? Could you please give me some advice. Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org