[ 
https://issues.apache.org/jira/browse/HADOOP-18029?focusedWorklogId=688365&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-688365
 ]

ASF GitHub Bot logged work on HADOOP-18029:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Dec/21 00:25
            Start Date: 01/Dec/21 00:25
    Worklog Time Spent: 10m 
      Work Description: Desmeister opened a new pull request #3739:
URL: https://github.com/apache/hadoop/pull/3739


   ### Description of PR
   
   I've updated the CompressionCodecFactory to be able to handle filenames with 
capitalized compression extensions. Two of the three existing internal maps 
used to store codecs have existing lowercase casts, but it is absent from the 
call inside getCodec() used for comparing path names.
   
   I updated the corresponding unit test in TestCodecFactory, to include 
intended use cases, and confirmed the test passes with the change. I also 
updated the error message in the case of a null from an NPE to a rich error 
message.
   
   ### How was this patch tested?
   
   I confirmed the updated TestCodecFactory:testFinding() test passes, and 
reran the test suite of hadoop-common.
   
   ### For code changes:
   
   - [Y] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [N/A] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [N/A] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [N/A] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 688365)
    Remaining Estimate: 0h
            Time Spent: 10m

> Update CompressionCodecFactory to handle uppercase file extensions
> ------------------------------------------------------------------
>
>                 Key: HADOOP-18029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18029
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common, io, test
>         Environment: Tested locally on macOS 11.6.1, IntelliJ IDEA 2021.2.3, 
> running maven commands through terminal. Forked from trunk branch on November 
> 29th, 2021.
>            Reporter: Desmond Sisson
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I've updated the CompressionCodecFactory to be able to handle filenames with 
> capitalized compression extensions. Two of the three existing internal maps 
> used to store codecs have existing lowercase casts, but it is absent from the 
> call inside getCodec() used for comparing path names.
> I updated the corresponding unit test in TestCodecFactory, to include 
> intended use cases, and confirmed the test passes with the change. I also 
> updated the error message in the case of a null from an NPE to a rich error 
> message.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to