[ 
https://issues.apache.org/jira/browse/HADOOP-18029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Desmond Sisson updated HADOOP-18029:
------------------------------------
    Description: 
I've updated the CompressionCodecFactory to be able to handle filenames with 
capitalized compression extensions. Two of the three existing internal maps 
used to store codecs have existing lowercase casts, but it is absent from the 
call inside getCodec() used for comparing path names.

I updated the corresponding unit test in TestCodecFactory, to include intended 
use cases, and confirmed the test passes with the change. I also updated the 
error message in the case of a null from an NPE to a rich error message.

  was:
I've updated the CompressionCodecFactory to be able to handle filenames with 
capitalized compression extensions. Two of the three existing internal maps 
used to store codecs have existing lowercase casts, but it is absent from the 
call inside getCodec() used for comparing path names.

I updated the corresponding unit test in TestCodecFactory, to include intended 
use cases, and confirmed the test passes with the change. I also updated the 
error message in the case of a null from an NPE to a rich error message.

GitHub PR Link: https://github.com/apache/hadoop/pull/3739


> Update CompressionCodecFactory to handle uppercase file extensions
> ------------------------------------------------------------------
>
>                 Key: HADOOP-18029
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18029
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: common, io, test
>         Environment: Tested locally on macOS 11.6.1, IntelliJ IDEA 2021.2.3, 
> running maven commands through terminal. Forked from trunk branch on November 
> 29th, 2021.
>            Reporter: Desmond Sisson
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I've updated the CompressionCodecFactory to be able to handle filenames with 
> capitalized compression extensions. Two of the three existing internal maps 
> used to store codecs have existing lowercase casts, but it is absent from the 
> call inside getCodec() used for comparing path names.
> I updated the corresponding unit test in TestCodecFactory, to include 
> intended use cases, and confirmed the test passes with the change. I also 
> updated the error message in the case of a null from an NPE to a rich error 
> message.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to