ashutoshcipher commented on pull request #3728: URL: https://github.com/apache/hadoop/pull/3728#issuecomment-983588923
> Thank you @ashutoshcipher for your PR. > > There are 3 duplicate code when opening levelDB files. Can we create a helper method in LeveldbUtils and reuse it? I think we can also make change in LeveldbTimelineStore to use the helper method. > > We can update the existing unit test to verify the behavior of the helper method. I have created a separate common method `loadOrRepairLevelDb` that is used by both LeveldbTimelineStore and TestRollingLevelDBTimelineStore -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
