aajisaka commented on a change in pull request #3677:
URL: https://github.com/apache/hadoop/pull/3677#discussion_r761552919
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/datatransfer/sasl/SaslDataTransferClient.java
##########
@@ -603,7 +603,20 @@ private IOStreamPair doSaslHandshake(InetAddress addr,
conf, cipherOption, underlyingOut, underlyingIn, false) :
sasl.createStreamPair(out, in);
} catch (IOException ioe) {
- sendGenericSaslErrorMessage(out, ioe.getMessage());
+ String message = ioe.getMessage();
+ try {
+ sendGenericSaslErrorMessage(out, message);
+ } catch (Exception e) {
+ // If ioe is caused by error response from server, server will close
peer connection.
+ // So sendGenericSaslErrorMessage might cause IOException due to
"Broken pipe".
+ // We suppress IOException from sendGenericSaslErrorMessage
+ // and always throw `ioe` as top level.
+ // `ioe` can be InvalidEncryptionKeyException or
InvalidBlockTokenException
+ // that indicates refresh key or token and are important for caller.
+ LOG.debug("Failed to send generic sasl error (server: {}, message:
{}), suppress exception",
+ addr.toString(), message, e);
Review comment:
Thank you for the update. In SLF4J API, `toString()` is not necessary.
Passing the Object instead of String allows lazy-evaluation and it skips
`toString()` method when the log level is not debug or trace.
```suggestion
addr, message, e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
