symious commented on pull request #3704: URL: https://github.com/apache/hadoop/pull/3704#issuecomment-988848771
@tasanuma Thanks for the review. > I have one question. This feature is similar to ECN. The configuration of ECN is dfs.pipeline.ecn, which is for the DataNode configuration. dfs.client.mark.slownode.as.badnode seems the client configuration I tried to digest the design of the code again. IMHO, the config of "dfs.pipeline.ecn" is like "dfs.pipeline.ecn.enable", the value of "true" means datanode should add the ECN information in PipelineAck, so this configuration is for DataNode to add or not add ECN. On Client side, there is no config for clients to choose if she should use ECN information, since it will use the information by default. In this ticket, I think a similar config of "dfs.pipeline.ecn" should be "dfs.pipeline.reply_slownode_in_pipeline_ack.enable", based on which DataNodes will choose to add or skip the slownode information in PipelineAck. On Client side, "dfs.client.mark.slownode.as.badnode" is more like "dfs.client.handle.ECN_from_pipelineACK". I think it's more depend on the subject of the operation, that is the subject of "dfs.pipeline.ecn" is DataNode, while the subject of "dfs.client.mark.slownode.as.badnode" is Client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
