shuzirra commented on a change in pull request #3799:
URL: https://github.com/apache/hadoop/pull/3799#discussion_r770173066
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/QueuePath.java
##########
@@ -61,12 +61,13 @@ public QueuePath(String fullPath) {
}
/**
- * Concatenate queue path parts into one queue path string.
- * @param parts Parts of the full queue pathAutoCreatedQueueTemplate
- * @return full path of the given queue parts
+ * Constructor to create Queue path from queue names.
+ * The provided queue names will be concatenated by dots, giving a full
queue path.
+ * @param queues Queue names
+ * @return QueuePath object
*/
- public static String concatenatePath(String... parts) {
- return String.join(DOT, parts);
+ public static QueuePath createFromQueues(String... queues) {
Review comment:
This is not necessarily an improvement, the strings are in fact parts of
the queue path, which are only short queue names, however those are ambiguous,
so calling them "queue" might be a bit misleading, since nothing guarantees you
can query these queues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
