[ https://issues.apache.org/jira/browse/HADOOP-18055?focusedWorklogId=700932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-700932 ]
ASF GitHub Bot logged work on HADOOP-18055: ------------------------------------------- Author: ASF GitHub Bot Created on: 24/Dec/21 09:12 Start Date: 24/Dec/21 09:12 Worklog Time Spent: 10m Work Description: aajisaka commented on pull request #3824: URL: https://github.com/apache/hadoop/pull/3824#issuecomment-1000741700 Thank you @virajjasani for your patch. This feature looks very helpful for us to investigate the root cause of some performance issues. I'll build and deploy Hadoop cluster and test this feature. Now I have one comment: We need to add an additional access control for this servlet like [ConfServlet](https://github.com/apache/hadoop/blob/e103c83765898f756f88c27b2243c8dd3098a989/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/ConfServlet.java#L61-L64). In addition, we need to update the document of `hadoop.security.instrumentation.requires.admin`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 700932) Time Spent: 1h (was: 50m) > Async Profiler endpoint for Hadoop daemons > ------------------------------------------ > > Key: HADOOP-18055 > URL: https://issues.apache.org/jira/browse/HADOOP-18055 > Project: Hadoop Common > Issue Type: New Feature > Reporter: Viraj Jasani > Assignee: Viraj Jasani > Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > Async profiler ([https://github.com/jvm-profiling-tools/async-profiler]) is a > low overhead sampling profiler for Java that does not suffer from Safepoint > bias problem. It features HotSpot-specific APIs to collect stack traces and > to track memory allocations. The profiler works with OpenJDK, Oracle JDK and > other Java runtimes based on the HotSpot JVM. > Async profiler can also profile heap allocations, lock contention, and HW > performance counters in addition to CPU. > We have an httpserver based servlet stack hence we can use HIVE-20202 as an > implementation template to provide async profiler as servlet for Hadoop > daemons. Ideally we achieve these requirements: > * Retrieve flamegraph SVG generated from latest profile trace. > * Online enable and disable of profiling activity. (async-profiler does not > do instrumentation based profiling so this should not cause the code gen > related perf problems of that other approach and can be safely toggled on and > off while under production load.) > * CPU profiling. > * ALLOCATION profiling. -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org