[ 
https://issues.apache.org/jira/browse/HADOOP-15789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486358#comment-17486358
 ] 

Steve Loughran commented on HADOOP-15789:
-----------------------------------------

* [~lawpremkumar] marked you as constributor & assigned JIRA
* can we have this as a github pr for the merge process?
* and [~ayushtkn] given the patch was someone else's code, you can +1 it 
yourself

lookiing at the code, checkstyle unhappy about javadocs

and unless it is critical to be made public, probably better to make cleanup() 
protected



> DistCp does not clean staging folder if class extends DistCp
> ------------------------------------------------------------
>
>                 Key: HADOOP-15789
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15789
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools/distcp
>            Reporter: Lawrence Andrews
>            Assignee: Lawrence Andrews
>            Priority: Minor
>         Attachments: HADOOP-15789-01.patch
>
>
> My code extends Distcp class and for some reason if distcp fails staging 
> folder is not delete and this staging folder piles up occupying space on hdfs.
> After checking the code i found that cleanup() function is private. Making 
> the cleanup() method as public, user should be able to invoke the cleanup if 
> job fails.
> This works fine with command line argument. But fails only if we extend 
> Distcp class.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to