[ https://issues.apache.org/jira/browse/HADOOP-18117?focusedWorklogId=726414&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-726414 ]
ASF GitHub Bot logged work on HADOOP-18117: ------------------------------------------- Author: ASF GitHub Bot Created on: 14/Feb/22 16:56 Start Date: 14/Feb/22 16:56 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on pull request #3970: URL: https://github.com/apache/hadoop/pull/3970#issuecomment-1039321135 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |:----:|----------:|--------:|:--------:|:-------:| | +0 :ok: | reexec | 0m 57s | | Docker mode activated. | |||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 1s | | codespell was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 3 new or modified test files. | |||| _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 32m 34s | | trunk passed | | +1 :green_heart: | compile | 0m 34s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | compile | 0m 32s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | checkstyle | 0m 27s | | trunk passed | | +1 :green_heart: | mvnsite | 0m 36s | | trunk passed | | +1 :green_heart: | javadoc | 0m 30s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 0m 50s | | trunk passed | | +1 :green_heart: | shadedclient | 20m 7s | | branch has no errors when building and testing our client artifacts. | |||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 0m 27s | | the patch passed | | +1 :green_heart: | compile | 0m 25s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | javac | 0m 25s | | the patch passed | | +1 :green_heart: | compile | 0m 23s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | javac | 0m 23s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 0m 16s | | hadoop-tools/hadoop-distcp: The patch generated 0 new + 46 unchanged - 1 fixed = 46 total (was 47) | | +1 :green_heart: | mvnsite | 0m 25s | | the patch passed | | +1 :green_heart: | javadoc | 0m 21s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 | | +1 :green_heart: | javadoc | 0m 19s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 0m 49s | | the patch passed | | +1 :green_heart: | shadedclient | 19m 42s | | patch has no errors when building and testing our client artifacts. | |||| _ Other Tests _ | | +1 :green_heart: | unit | 43m 50s | | hadoop-distcp in the patch passed. | | +1 :green_heart: | asflicense | 0m 34s | | The patch does not generate ASF License warnings. | | | | 126m 38s | | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3970/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/3970 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell | | uname | Linux 41d15546ac18 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / f62d3c39a16920aa88cfa67ee7a56562d24c6b7d | | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3970/5/testReport/ | | Max. process+thread count | 742 (vs. ulimit of 5500) | | modules | C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3970/5/console | | versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 | | Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 726414) Time Spent: 2h (was: 1h 50m) > Add an option to preserve root directory permissions > ---------------------------------------------------- > > Key: HADOOP-18117 > URL: https://issues.apache.org/jira/browse/HADOOP-18117 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Mohanad Elsafty > Assignee: Mohanad Elsafty > Priority: Minor > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > As mentioned in https://issues.apache.org/jira/browse/HADOOP-15211 > > If *-update* or *-overwrite* is being passed when *distcp* used, the root > directory will be skipped in two occasions (CopyListing#doBuildListing & > CopyCommitter#preserveFileAttributesForDirectories), which will ignore root > directory's attributes. > > We face the same issue when distcp huge data between clusters and it takes > too much effort to update root directories attributes manually. > > From the earlier ticket it's obvious why this behaviour is there, but > sometime we need to enforce root directory update hence I will add a new > option for distcp to enable someone (who understands the need of this and > know what they are doing) to enforce the update of root directory's > attributes (permissions, ownership, ...) > > It should be simple one, something like this > {code:java} > $ hadoop distcp -p -update -updateRootDirectoryAttributes /a/b/c /a/b/d {code} > This behaviour is optional and will be *false* by default. (it should not > affect existing *distcp* users). -- This message was sent by Atlassian Jira (v8.20.1#820001) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org