simbadzina commented on a change in pull request #4024:
URL: https://github.com/apache/hadoop/pull/4024#discussion_r814105513
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/curator/ZKCuratorManager.java
##########
@@ -428,4 +434,26 @@ public void setData(String path, byte[] data, int version)
.forPath(path, data));
}
}
+
+ public static class HadoopZookeeperFactory implements ZookeeperFactory {
+ private final String zkPrincipal;
+
+ public HadoopZookeeperFactory(String zkPrincipal) {
+ this.zkPrincipal = zkPrincipal;
+ }
+
+ @Override
+ public ZooKeeper newZooKeeper(String connectString, int sessionTimeout,
+ Watcher watcher, boolean canBeReadOnly
+ ) throws Exception {
+ ZKClientConfig zkClientConfig = new ZKClientConfig();
+ if (zkPrincipal != null) {
+ LOG.info("Configuring zookeeper client to use {}", zkPrincipal);
Review comment:
Can you add "as the server principal" at the end of the log message so
that it's clear what the value is being used for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
