[
https://issues.apache.org/jira/browse/HADOOP-18145?focusedWorklogId=734383&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-734383
]
ASF GitHub Bot logged work on HADOOP-18145:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/22 07:37
Start Date: 01/Mar/22 07:37
Worklog Time Spent: 10m
Work Description: zhongjingxiong commented on a change in pull request
#4036:
URL: https://github.com/apache/hadoop/pull/4036#discussion_r816435439
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java
##########
@@ -726,7 +727,10 @@ public void testUnZip() throws IOException {
// check result:
assertTrue(new File(tmp, "foo").exists());
assertEquals(12, new File(tmp, "foo").length());
-
+ assertTrue(new File(tmp, "foo").canExecute());
+ assertTrue(new File(tmp, "foo").canRead());
+ assertTrue(new File(tmp, "foo").canWrite());
Review comment:
1.This is a good test scenario, but windows system does not have the
permission information of group/other IIRC.
2.If it is a Windows operating platform, it will skip the permission logic,
because the Windows system itself does not have detailed executable permission,
only read and write permission,the method of canExecute defaults to true on
Windows systems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 734383)
Time Spent: 2h 50m (was: 2h 40m)
> Fileutil's unzip method causes unzipped files to lose their original
> permissions
> --------------------------------------------------------------------------------
>
> Key: HADOOP-18145
> URL: https://issues.apache.org/jira/browse/HADOOP-18145
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 2.7.2
> Reporter: jingxiong zhong
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> When Spark decompresses the zip file, if the original file has the executable
> permission, but the unzip method of FileUtil is invoked, the decompressed
> file loses the executable permission, we should save the original permission
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
