steveloughran commented on a change in pull request #2971: URL: https://github.com/apache/hadoop/pull/2971#discussion_r819743248
########## File path: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/output/committer/manifest/files/package-info.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +/** + * Persistence formats. + * These are the persistence formats used for passing data from tasks + * to the job committer + * {@link org.apache.hadoop.mapreduce.lib.output.committer.manifest.files.TaskManifest}, + * and for a {@code _SUCCESS} file, which is in + * {@link org.apache.hadoop.mapreduce.lib.output.committer.manifest.files.ManifestSuccessData}. + * The {@code _SUCCESS} file is a copy of the S3A Committer + * {@code org.apache.hadoop.fs.s3a.commit.files.ManifestSuccessData}, + * the intent being that at the JSON-level they are compatible. + * This is to aid testing/validation and support calls, with one single + * format to load. + * + * Consult the individual formats for their declarations of access; + * the _SUCCESS file is one which tests may use. + * + */ +@InterfaceAudience.Public Review comment: yes. i use it in my downstream spark tests, which take the list of files committed and verify they match expectations, and that the committer is the one requested. saving all summaries to a report dir has opportunities for the future, such as reviewing work. if we can get the full task thread's stats in there, it'd be wonderful (todo: task level iostats) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
