[ https://issues.apache.org/jira/browse/HADOOP-6897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176833#comment-13176833 ]
Harsh J commented on HADOOP-6897: --------------------------------- I second Nicholas' comment: bq. I think that the static mkdirs(..) is confusing to users. There are only a few lines of codes inside. Why don't we just deprecate it now and remove it in the future? This should already be covered by the FileSystem#mkdir/mkdirs methods now. I do not see why we should have a static method for mkdirs and create anymore. > FileSystem#mkdirs(FileSystem, Path, FsPermission) should not call > setPermission if mkdirs failled > ------------------------------------------------------------------------------------------------- > > Key: HADOOP-6897 > URL: https://issues.apache.org/jira/browse/HADOOP-6897 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 0.22.0 > Reporter: Hairong Kuang > Assignee: Hairong Kuang > Attachments: mkdirs.patch > > > Here is the piece of code that has the bug. fs.setPermission should not be > called if result is false. > {code} > public static boolean mkdirs(FileSystem fs, Path dir, FsPermission > permission) > throws IOException { > // create the directory using the default permission > boolean result = fs.mkdirs(dir); > // set its permission to be the supplied one > fs.setPermission(dir, permission); > return result; > } > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira