xinglin commented on a change in pull request #4034: URL: https://github.com/apache/hadoop/pull/4034#discussion_r820035684
########## File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java ########## @@ -191,8 +191,8 @@ public boolean moveToTrash(Path path) throws IOException { cause = e; } } - throw (IOException) - new IOException("Failed to move to trash: " + path).initCause(cause); + throw (IOException) new IOException( Review comment: Technically, this change is not related with our new trash policy. However, during the debugging process, we found it quite difficult to track where the file is being moved when we failed to do so. moveToTrash() function does not print the trash root path. Thus, I added this change when we failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org