ahmarsuhail commented on a change in pull request #3927:
URL: https://github.com/apache/hadoop/pull/3927#discussion_r827130861
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java
##########
@@ -781,6 +781,46 @@ public void readFully(long position, byte[] buffer, int
offset, int length)
}
}
+ /**
+ * {@inheritDoc}
+ *
+ * This implements a more efficient method for skip. It calls lazy seek
+ * which will either make a new get request or do a default skip.
+ * If lazy seek fails, try doing a default skip.
+ *
+ * @param n Number of bytes to be skipped
+ * @return Number of bytes skipped
+ * @throws IOException on any problem
+ */
+ @Override
+ @Retries.OnceTranslated
+ public long skip(final long n) throws IOException {
+
+ if (n <= 0) {
+ return 0;
+ }
+
+ checkNotClosed();
+ streamStatistics.skipOperationStarted();
+
+ long targetPos = pos + n;
Review comment:
from what I understand getPos() returns `nextReadPos` which is currently
not updated in `reopen()` or `seekInStream()`. To do that, I can add
`nextReadPos = targePos` after
[this](https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L239)
&
[this](https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L352),
and also `nextReadPos += skipped` after
[this](https://github.com/apache/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L313),
but not sure if we want to do this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
