[ 
https://issues.apache.org/jira/browse/HADOOP-18160?focusedWorklogId=742396&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-742396
 ]

ASF GitHub Bot logged work on HADOOP-18160:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Mar/22 14:30
            Start Date: 16/Mar/22 14:30
    Worklog Time Spent: 10m 
      Work Description: andreAmorimF opened a new pull request #4074:
URL: https://github.com/apache/hadoop/pull/4074


   ### Description of PR
   
   `org.wildfly.openssl` is a runtime library and its references are being 
shaded on Hadoop, breaking the integration with other frameworks like Spark, 
whenever the "fs.s3a.ssl.channel.mode" is set to "openssl". The error produced 
in this situation is:
   
   ```
   Suppressed: java.lang.NoClassDefFoundError: 
org/apache/hadoop/shaded/org/wildfly/openssl/OpenSSLProvider
   ```
   
   This PR aims to exclude `org.wildfly.openssl` from the shade, keeping the 
original namespace to be referenced whenever this runtime dependency is added 
to the classpath. 
   
   ### How was this patch tested?
   
   Used the patched jar on a Spark 3.2.1 application which now correctly 
references the `org.wildfly.openssl` dependency added to the classpath.
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 742396)
    Remaining Estimate: 0h
            Time Spent: 10m

> `org.wildfly.openssl` should not be shaded by Hadoop build
> ----------------------------------------------------------
>
>                 Key: HADOOP-18160
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18160
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.3.1
>         Environment: hadoop 3.3.1
> spark 3.2.1
> JDK8
>            Reporter: André F.
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> `org.wildfly.openssl` is a runtime library and its references are being 
> shaded on Hadoop, breaking the integration with other frameworks like Spark, 
> whenever the "fs.s3a.ssl.channel.mode" is set to "openssl". The error 
> produced in this situation is:
> {code:java}
> Suppressed: java.lang.NoClassDefFoundError: 
> org/apache/hadoop/shaded/org/wildfly/openssl/OpenSSLProvider{code}
> Whenever it tries to be instantiated from the `DelegatingSSLSocketFactory`. 
> Spark tries to add it to its classpath without the shade, thus creating this 
> issue.
> Dependencies which are not on "compile" scope should probably not be shaded 
> to avoid this kind of integration issues.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to