dannycjones commented on a change in pull request #4070:
URL: https://github.com/apache/hadoop/pull/4070#discussion_r832005639
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
##########
@@ -142,6 +142,10 @@ private Constants() {
public static final String ASSUMED_ROLE_CREDENTIALS_DEFAULT =
SimpleAWSCredentialsProvider.NAME;
+ /**
+ * Absolute path to the web identity token file
+ */
+ public static final String JWT_PATH = "fs.s3a.jwt.path";
Review comment:
If its for OIDC / WebIdentity, can we change to something like
`fs.s3a.oidc.jwt.path` / `fs.s3a.webidentity.jwt.path`?
+ add `@value` to JavaDoc for IDE hints?
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
##########
@@ -142,6 +142,10 @@ private Constants() {
public static final String ASSUMED_ROLE_CREDENTIALS_DEFAULT =
SimpleAWSCredentialsProvider.NAME;
+ /**
+ * Absolute path to the web identity token file
+ */
+ public static final String JWT_PATH = "fs.s3a.jwt.path";
Review comment:
If its for OIDC / WebIdentity, can we change to something like
`fs.s3a.oidc.jwt.path` / `fs.s3a.webidentity.jwt.path`?
Also, add `@value` to JavaDoc for IDE hints?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
